ensure unique labels in import-dictionaries #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we have enhanced dictionaries where labels with the same name will be added and always an exception due to a doubled alias will be thrown. With this approach we suffix the labels with the name to ensure uniqueness. Example: WEIGHT and NET_WEIGHT both are translated with "Gewicht" and added to the same import-dictionary will result in "Gewicht" and "Gewicht_NET_WEIGHT" now. - fixes: SE-13234
mkeckmkeck
approved these changes
Feb 8, 2024
jakobvogel
approved these changes
Feb 8, 2024
mko-sci
approved these changes
Feb 8, 2024
fhaScireum
reviewed
Feb 8, 2024
The problem is, that previously "WEIGHT" and "WEIGHT_SUPER" would both have their label "Gewicht" displayed in the job description. But when actually using "Gewicht" in an import, only one of them would have been used. |
fhaScireum
approved these changes
Feb 8, 2024
idlira
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes we have enhanced dictionaries where labels with the same name will be added and always an exception due to a doubled alias will be thrown. With this approach we suffix the labels with the name to ensure uniqueness. Example: WEIGHT and NET_WEIGHT both are translated with "Gewicht" and added to the same import-dictionary will result in "Gewicht" and "Gewicht_NET_WEIGHT" now. (see Screenshots)
Additional Notes
Checklist